Skip to content

Fix counting and filtering on the dashboard page for issues#26657

Merged
techknowlogick merged 21 commits intogo-gitea:mainfrom
wolfogre:bugfix/count_issues
Aug 23, 2023
Merged

Fix counting and filtering on the dashboard page for issues#26657
techknowlogick merged 21 commits intogo-gitea:mainfrom
wolfogre:bugfix/count_issues

Conversation

@wolfogre
Copy link
Copy Markdown
Member

@wolfogre wolfogre commented Aug 22, 2023 •
edited
Loading

This PR actually has multiple parts, and I didn't split them because it's not easy to test them separately since they are all about the dashboard page for issues.

  1. Support counting issues via indexer, to fix The incoming request has too many parameters. This server supports a maximum of 2100 parameters.  #26361
  2. Fix repo selection, so it also fix Incorrect selection behavior at repo list , on the left side of the issues page. #26653
  3. Keep keyword in filter links.

The first two are regressions of #26012.

After:

Screen.Recording.2023-08-22.at.17.51.28.mov

Thanks to @CaiCandong for helping with some tests.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 22, 2023
@wolfogre wolfogre added type/bug and removed size/L labels Aug 22, 2023
@wolfogre wolfogre requested a review from CaiCandong August 22, 2023 07:54
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 22, 2023
@zjjhot
Copy link
Copy Markdown
Contributor

zjjhot commented Aug 22, 2023

Thank you very much. I have a suggestion.

Issues that have existed in history can be displayed in the repo list (even if this issue module is prohibited from accessing, it is reasonable to exist, and I can always see records of historical existence, which is fine).

However, those that have never been issued (count=0) should not be displayed in the repo list, especially those repos that disabled by issue module.

@wolfogre
Copy link
Copy Markdown
Member Author

wolfogre commented Aug 22, 2023

Issues that have existed in history can be displayed in the repo list (even if this issue module is prohibited from accessing, it is reasonable to exist, and I can always see records of historical existence, which is fine).

Not sure, maybe another PR.

However, those that have never been issued (count=0) should not be displayed in the repo list, especially those repos that disabled by issue module.

Done in e56c59a

@CaiCandong
Copy link
Copy Markdown
Member

CaiCandong commented Aug 22, 2023 

	for k, v := range issueCountByRepo {
		if _, ok := selectedReposMap[k]; !ok && v == 0 {
			delete(issueCountByRepo, k)
		}
	}

Maybe we can use https://pkg.go.dev/maps@go1.21.0#DeleteFunc

@wolfogre
Copy link
Copy Markdown
Member Author

wolfogre commented Aug 22, 2023

Maybe we can use pkg.go.dev/maps@go1.21.0#DeleteFunc

Not now, Gitea is still using go1.20:

gitea/go.mod

Line 3 in 1432d4e

go 1.20

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 22, 2023
@lunny lunny mentioned this pull request Aug 23, 2023
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 23, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 23, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) August 23, 2023 01:31
@techknowlogick techknowlogick merged commit 5db21ce into go-gitea:main Aug 23, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 23, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 23, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 23, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a34a70c 
* giteaofficial/main:
  Fix counting and filtering on the dashboard page for issues (go-gitea#26657)
  add mfa doc (go-gitea#26654)
  [Refactor] getIssueStatsChunk to move inner function into own one (go-gitea#26671)
  Use line-height: normal by default (go-gitea#26635)
  Improve repo sub menu (go-gitea#26531)
  Fix organization list in dashboard (go-gitea#26650)
@lunny lunny mentioned this pull request Aug 23, 2023
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@CaiCandong CaiCandong CaiCandong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Milestone

1.21.0

7 participants

@wolfogre @zjjhot @CaiCandong @lunny @wxiaoguang @techknowlogick @GiteaBot